Split JS and CSS loading of the polyfill #217
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #160.
Not sure if we do want to have this though, as it will leave Firefox Nightly somewhat useless state for CSS-based SDA’s.
With the changes in this PR, the polyfill won’t kick for the CSS part but will for the JS part in Firefox Nightly. However, because Firefox Nightly supports an older CSS syntax (e.g. using
vertical
instead ofy
, or requiring an time-basedanimation-duration
) this will leave CSS Scroll-Driven Animations in a broken state.One thing I do like about this PR is the code restructure that splits off the JS plugging into
scroll-timeline-js.js
.