Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot change voice name 2 times #373

Open
pokorj54 opened this issue Sep 4, 2022 · 3 comments
Open

Cannot change voice name 2 times #373

pokorj54 opened this issue Sep 4, 2022 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@pokorj54
Copy link
Member

pokorj54 commented Sep 4, 2022

If executing this series of commands,

::voice add
::voice edit A
::voice edit B

The channel will remain at name A

@pokorj54 pokorj54 added the bug Something isn't working label Sep 4, 2022
@stepech
Copy link
Contributor

stepech commented Sep 4, 2022

Rate limit's fault - add special message when bot hits rate limit. (Instead of generic fail message or just timed out response)

@jirkavrba
Copy link
Contributor

jirkavrba commented Sep 4, 2022

How about reacting with ⌛ and deferring the API request instead?

@stepech
Copy link
Contributor

stepech commented Sep 4, 2022

That could become too complicated very quickly.. What if the channel is deleted when the final request happens? What if someone else requests to change the channel's name? Do I put it in queue, or count just last? What if the name itself is invalid (You find it only after you send a request)? What if bot reboots? Also, how do I know how long the rate limit lasts? DSharpPlus is quite restrictive in this, doubt we could access rate limit buckets...

Easiest to implement is just that special response..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Development

No branches or pull requests

5 participants