New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add security headers #21

Closed

julienw opened this issue Nov 18, 2019 · 1 comment · Fixed by #30

Labels

Contributor

julienw commented Nov 18, 2019

add CORS
add HSTS
add CSP

I'd suggest to use https://github.com/venables/koa-helmet like Firefox Send does (see https://github.com/mozilla/send/blob/master/server/routes/index.js), because it seems more maintained than alternatives.

Contributor Author

julienw commented Nov 18, 2019 •

edited

Loading

relevant CSP recommendations from #18:

a report-uri pointing to the service's own /__cspreport__ endpoint
web API responses should return default-src 'none'; frame-ancestors 'none'; base-uri 'none'; report-uri /__cspreport__ to disallowing all content rendering, framing, and report violations

from #18, HSTS should be 31536000 (1 year).

julienw added the security label

julienw mentioned this issue

Add security headers #30

Merged

julienw closed this as completed in #30

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment