Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

firebug.sdk version dependency is hardcoded #65

Open
aliuk2012 opened this issue Apr 27, 2015 · 6 comments
Open

firebug.sdk version dependency is hardcoded #65

aliuk2012 opened this issue Apr 27, 2015 · 6 comments
Assignees

Comments

@aliuk2012
Copy link
Contributor

Allow npm install to ignore minor version of firebug.sdk but respect major versions

@aliuk2012 aliuk2012 self-assigned this Apr 27, 2015
@cadorn
Copy link
Member

cadorn commented Apr 27, 2015

I have been using the x variant to slip the patch version as it seems to work most reliably when updating the installed dep to a new patch version:

"dependencies": {
    "firebug.sdk": "0.5.x"
}

@cadorn
Copy link
Member

cadorn commented Apr 27, 2015

You can also do 0.x but I usually keep the minor version until a lib reaches at least 1.0.

@fflorent
Copy link
Member

It is not really a big deal to have a version hardcoded. It is even IMHO a good practice : it means the code has been tested with the specified version of the dependency (and avoid regressions because of an update of it).

If an update of it is available, that's the work of the maintainer to update the package.json file and test again their work.

Just my two cents.

Florent

@cadorn
Copy link
Member

cadorn commented Apr 27, 2015

I essentially agree. I will have a tool to alert us and auto-test new versions for each extension.

@aliuk2012
Copy link
Contributor Author

@fflorent I would normally agree but as we get more extensions it will get harder to maintain. I like @cadorn idea of having a tool alert us and then for it to rerun the tests.

Ok, should we leave the minor version in for the time being and just relax the patch version?

@aliuk2012
Copy link
Contributor Author

Actually this repo is a good example, firebug.sdk is already on 0.5.8 where pixel perfect is looking for and trying to use 0.5.5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants