Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Auth] Use 'password' for Email/Password provider ID #1201

Merged
merged 3 commits into from
Aug 16, 2024
Merged

[Auth] Use 'password' for Email/Password provider ID #1201

merged 3 commits into from
Aug 16, 2024

Conversation

ncooke3
Copy link
Member

@ncooke3 ncooke3 commented Aug 15, 2024 •
edited
Loading

Fix #1199

@ncooke3 ncooke3 requested a review from paulb777 August 15, 2024 23:37
paulb777
paulb777 approved these changes Aug 15, 2024
View reviewed changes
Copy link
Member

@paulb777 paulb777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One issue and then LGTM on green

Thanks!

samples/objc/FirebaseUI-demo-objc/Samples/Auth/FUIAuthViewController.m Outdated Show resolved Hide resolved
@paulb777
Copy link
Member

FYI I reviewed by running git grep @\"email\" at various points in the commit history

@ncooke3 ncooke3 merged commit 81052b4 into main Aug 16, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulb777 paulb777 paulb777 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Version 14 issues after upgrading to latest version
2 participants
@ncooke3 @paulb777