Add bottom divider to SettingsViewIconCell (needed for accessibility statement task) #1342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why?
FINN.no has an accessibility statement, reachable on Tilgjengelighetserklæring på FINN. This needs to be added to the Finn ios and android apps.
What?
Background is described here: Jira
Corresponding PR for ios-app: Here
Due to the fact that SettingsViewIconCell is a swiftui with a bit different logic than ex. SettingsDetailsItem (-> SettingsViewCell), I had to add a bottom divider to it. A very similar view modifier already exist inside FinnUI. Ideally I guess Settings specific code like this could be living in FinnUI instead of FinniversKit, and therefore I made a quick attempt of moving it. This caused a bunch of errors, mainly due to duplications in naming . I reverted, and created the bottom divider instead.
Version Change
The change is minor.
UI Changes