Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

non-void-return issue in 3.0.0 #129

Open
dhzl84 opened this issue Aug 24, 2021 · 6 comments
Open

non-void-return issue in 3.0.0 #129

dhzl84 opened this issue Aug 24, 2021 · 6 comments

Comments

@dhzl84
Copy link

dhzl84 commented Aug 24, 2021

Expected behavior

Version 3.0.0 should not throw return type errors fixed with #121.

Actual behavior

Eventhough PlatformIO states that it downloaded version 3.0.0, the functions in the downloaded code still have the return type bool.

Builds fail locally as well as on GH Actions.

Steps to reporduce the behavior

I use PlatformIO to get the library.

platformio.ini:

lib_deps = 
	finitespace/BME280 @ ^3.0.0

Library Installation by PlatformIO:

Library Manager: Installing finitespace/BME280 @ ^3.0.0
Downloading...
Unpacking...
Library Manager: BME280 @ 3.0.0 has been installed!

PlatformIO build console:

Dependency Graph
|-- <BME280> 3.0.0
.pio\libdeps\8266_thermostat_debug\BME280\src\BME280.cpp: In member function 'bool BME280::InitializeFilter()':
.pio\libdeps\8266_thermostat_debug\BME280\src\BME280.cpp:85:1: error: no return statement in function returning non-void [-Werror=return-type]
   85 | }
      | ^
.pio\libdeps\8266_thermostat_debug\BME280\src\BME280.cpp: In member function 'bool BME280::WriteSettings()':
.pio\libdeps\8266_thermostat_debug\BME280\src\BME280.cpp:122:1: error: no return statement in function returning non-void [-Werror=return-type]
  122 | }
      | ^

There seems to be an issue in the library registry.
Version 3.0.0 has two release dates, maybe same version published twice?
I browsed the history of my platformio.ini and already used version 3.0.0 in January 2020.

image

and

image

Hope you find the time to have a look into that?

@MacSass
Copy link

MacSass commented Oct 18, 2021

I do have the same issue ... re-installed VME280 lib on platform-IO, shows as version 3.0.0, but still has the bool in it as return type ...

@MacSass
Copy link

MacSass commented Oct 18, 2021

Manual download and install to platformio fixed the issue ... looks like the old version is still on the repository!

@villafapd
Copy link

I had the same problem and I solved it by manually downloading the library.

@lekimtek
Copy link

lekimtek commented Dec 13, 2021

The same for me, not working. I tested install by git clone of entire master and not work and it still installing by platfomio.
The solution is downloading manually and changing only src directory, this stop install by platformio and uses the library OK, in global mode too.

May be the problem is in how to install library platformio?

@lekimtek
Copy link

lekimtek commented Jan 4, 2022

Update!
I installed manually "src" dir from branch 3.0.1-dev and not work, same error like installed by platformio.
Aclaration:

This not work and may be 3.0.1-dev version is installed by platformio instead 3.0.0
git clone -b 3.0.1-dev https://github.com/finitespace/BME280.git

This work fine if is installed manually not by platformio.
git clone https://github.com/finitespace/BME280.git

Where is the error?
May be platformio search latest and install 3.0.1-dev?

Solution:
Please reorder library branches and versions, may be like new one version... I dont now...

@studiofuga
Copy link

See #130 (comment) on issue #130

Solution: Publish an updated version on platform.io.

Workaround: specify the git URL on platformio.ini:

lib_deps = 
            BME280=https://github.com/finitespace/BME280.git

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants