Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added in the normalizeWheel functions and supporting code so that the… #1

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

nsivraj
Copy link

@nsivraj nsivraj commented Jun 16, 2017

… mouse wheel movements are normalized in all different browsers

… mouse wheel movements are normalized in all different browsers
@joneit joneit force-pushed the master branch 3 times, most recently from 8de3a88 to 4210cda Compare May 24, 2018 20:13
@joneit
Copy link
Contributor

joneit commented Oct 6, 2018

I regret this was overlooked. It seems like a great solution and we will definitely want to incorporate it. It cannot however be merged in its current state due to:

  1. .spinY needs to be updated to [this.spinProp] (which needs to be created)
  2. Out of date; needs to factor in the deltaXFactor and deltaYFactor props added subsequently

We should also check to see if FB has updated their code in any way.

If you are no longer available or interested, I will close this PR and submit a new one with the above changes. lmk

@joneit joneit force-pushed the master branch 3 times, most recently from a2c13b1 to 9b5fca1 Compare October 29, 2018 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants