Skip to content
This repository has been archived by the owner on May 15, 2024. It is now read-only.

feat: expose deal ID as replica ID #217

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

feat: expose deal ID as replica ID #217

wants to merge 1 commit into from

Conversation

rvagg
Copy link
Member

@rvagg rvagg commented Nov 7, 2023

Closes: #216

If we want to take the approach of adding uniqueness by exposing the deal ID, which is unique in the Singularity database but increments with each deal. Are there concerns with exposing this number? Does it leak anything interesting if you have a multi-user system? Perhaps multi-user is something that's handled downstream and can be filtered out if necessary?

@codecov-commenter
Copy link

Codecov Report

Merging #217 (401d368) into main (63ceec3) will increase coverage by 7.16%.
Report is 9 commits behind head on main.
The diff coverage is 0.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #217      +/-   ##
==========================================
+ Coverage   31.66%   38.82%   +7.16%     
==========================================
  Files           5        6       +1     
  Lines         777      904     +127     
==========================================
+ Hits          246      351     +105     
- Misses        494      507      +13     
- Partials       37       46       +9     
Files Coverage Δ
blob/blob.go 37.50% <ø> (ø)
integration/singularity/store.go 35.87% <0.00%> (-0.66%) ⬇️

... and 4 files with indirect coverage changes

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Blob status API schema discussion: replicas array has no obvious uniqueness property
2 participants