Skip to content
This repository has been archived by the owner on May 15, 2024. It is now read-only.

fix: fill/rename LastVerified -> LastUpdated in replica #136

Merged
merged 2 commits into from
Oct 6, 2023

Conversation

elijaharita
Copy link
Contributor

@elijaharita elijaharita commented Sep 23, 2023

this PR also includes a fix for a bug my last PR introduced where preparation job loop immediately closes on startup

closes #132
closes #137

@elijaharita elijaharita marked this pull request as ready for review September 27, 2023 10:34
@elijaharita elijaharita changed the title fix: fill LastVerified in replica fix: fill/rename LastUpdated in replica Sep 27, 2023
@elijaharita elijaharita changed the title fix: fill/rename LastUpdated in replica fix: fill/rename LastVerified -> LastUpdated in replica Sep 27, 2023
@masih
Copy link
Member

masih commented Oct 1, 2023

Also update the open API spec?

@elijaharita
Copy link
Contributor Author

@masih ah, didn't know we had this. good to know, i'll do that

@elijaharita
Copy link
Contributor Author

also, i will wait for integration test to merge, it fixes a bug that will allow ci to pass

@masih
Copy link
Member

masih commented Oct 5, 2023

@elijaharita the integration test PR is now merged, this PR should be good to go?

@codecov-commenter
Copy link

Codecov Report

Merging #136 (0f557e6) into main (c38b9f6) will decrease coverage by 0.13%.
The diff coverage is 0.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #136      +/-   ##
==========================================
- Coverage   31.83%   31.70%   -0.13%     
==========================================
  Files           5        5              
  Lines         735      738       +3     
==========================================
  Hits          234      234              
- Misses        466      469       +3     
  Partials       35       35              
Files Coverage Δ
blob/blob.go 37.50% <ø> (ø)
integration/singularity/store.go 36.76% <0.00%> (-0.25%) ⬇️

@elijaharita elijaharita merged commit 5cfdd22 into main Oct 6, 2023
8 checks passed
@elijaharita elijaharita deleted the fix/last-verified branch October 6, 2023 23:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename lastVerified to lastUpdated Report the latest deal check timestamp from Singularity as LastVerified
3 participants