Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Algorithms: Change algorithms class into an Interface #40

Open
chalkie666 opened this issue Aug 24, 2015 · 0 comments
Open

Algorithms: Change algorithms class into an Interface #40

chalkie666 opened this issue Aug 24, 2015 · 0 comments

Comments

@chalkie666
Copy link
Collaborator

Suggestion from Dscho:

"Rethink Algorithm, and perhaps rename it into something that is actually useful. Make it interface-driven. Make sure that the interface is minimal. It is okay to have an abstract base class implementing that interface, but it is not okay to require every analysis type to extend it, that is just a recipe for trouble because it encourages callers to use features that happen to be implementation details, rather than only what the interface defines.

Split the functionality of the Algorithm interface into several aspects:
display is separate from calculating the data,
PDF display is separate from screen output."

This kind of thing is also related to the proposed migration of some general calculations such as Pearsons r from coloc_2 into ops. see issue #12

@etadobson etadobson added this to the m1 milestone Oct 2, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants