Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] TO2: Unsupported test for all FIDO_TEST_LIST_VOUCHER #41

Open
2 of 6 tasks
quanvincss opened this issue Sep 22, 2023 · 2 comments
Open
2 of 6 tasks

[BUG] TO2: Unsupported test for all FIDO_TEST_LIST_VOUCHER #41

quanvincss opened this issue Sep 22, 2023 · 2 comments
Assignees

Comments

@quanvincss
Copy link

To simplify issue resolution process, please provide network logs, and or test voucher.
image

What part of the spec are you testing?

  • Rendezvous Server
  • Device Onboarding Service
  • Device Implementation

What protocol are having issue with?

  • TO0
  • TO1
  • TO2

Issue description

The conformance server does not check response for group test FIDO_TEST_LIST_VOUCHER
https://github.com/fido-alliance/fdo-fido-conformance-server/blob/bed48409e41da82fc603fa89ef645ca8cc5acb14/core/device/to2/to2-common.go#L44

@quanvincss quanvincss changed the title [BUG] Unsupported test for all FIDO_TEST_LIST_VOUCHER [BUG] TO2: Unsupported test for all FIDO_TEST_LIST_VOUCHER Sep 22, 2023
@yackermann
Copy link
Contributor

Try deleting badgerdb and re-seed it via ./fdo-fido-conformance-server seed

@quanvincss
Copy link
Author

Try deleting badgerdb and re-seed it via ./fdo-fido-conformance-server seed

It does not seem to be a DB issue, in To2 test, FIDO_TEST_LIST_VOUCHER is used in executeTo2_60_Vouchers:
https://github.com/fido-alliance/fdo-fido-conformance-server/blob/bed48409e41da82fc603fa89ef645ca8cc5acb14/testexec/do.to2.60.vouchers.execute.go#L13

inside that function, you call to2requestor.HelloDevice60:
https://github.com/fido-alliance/fdo-fido-conformance-server/blob/bed48409e41da82fc603fa89ef645ca8cc5acb14/testexec/do.to2.60.vouchers.execute.go#L30

then in HelloDevice60, you send msg60 request and check response in confCheckResponse:
https://github.com/fido-alliance/fdo-fido-conformance-server/blob/bed48409e41da82fc603fa89ef645ca8cc5acb14/core/device/to2/req-to2-60-HelloDevice.go#L40

but inside function confCheckResponse, you didn't check response for FIDO_TEST_LIST_VOUCHER and it returns "false" by default:
https://github.com/fido-alliance/fdo-fido-conformance-server/blob/bed48409e41da82fc603fa89ef645ca8cc5acb14/core/device/to2/to2-common.go#L65

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants