Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for app termination #6

Open
fgm opened this issue Feb 26, 2023 · 0 comments
Open

Add support for app termination #6

fgm opened this issue Feb 26, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@fgm
Copy link
Owner

fgm commented Feb 26, 2023

Some services define a method to be called on termination, often a func (Foo) Close() error to implement io.Closer.

Currently, the container users need to know exactly which services need that, and call these functions in main.

It would be nicer to have the container support auto-closing, by allowing services to register some special termination optional interface the container could close in a single call to err := dic.Close(). The main issue is to ensure closure in in the inverse order of instantation to avoid breaking dependencies.

@fgm fgm added the enhancement New feature or request label Feb 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant