Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up warnings #26

Open
subversive-owl opened this issue Nov 6, 2017 · 3 comments
Open

Clean up warnings #26

subversive-owl opened this issue Nov 6, 2017 · 3 comments
Assignees
Labels
bug Something doesn't quite look right

Comments

@subversive-owl
Copy link
Contributor

The crate issues quite a few warnings. Some of the unneeded identifiers could be intentional for later implementation, but at the moment it creates a lot of compiler output to sift through. Removing the warnings would also ensure the codebase is readable for humans and compilers the same way.

@drahnr
Copy link
Member

drahnr commented Nov 6, 2017

I am for the _ addons, but it is hard to test since it depends on the backend selection which warnings are spawn.

@drahnr drahnr self-assigned this Nov 7, 2017
@drahnr drahnr added the bug Something doesn't quite look right label Nov 7, 2017
@drahnr
Copy link
Member

drahnr commented Nov 7, 2017

But yes, this is something definitely to be taken care of, especially to de-clutter the build process.

@subversive-owl
Copy link
Contributor Author

that's a good point though, i really doubt rustc team want to try to untangle checking feature-conditional warnings automatically, so i doubt there's much we can do for the time being.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something doesn't quite look right
Projects
None yet
Development

No branches or pull requests

2 participants