Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Task 6 use mobile_concentration() instead of solution #47

Open
RemDelaporteMathurin opened this issue Mar 15, 2024 · 0 comments
Open

Task 6 use mobile_concentration() instead of solution #47

RemDelaporteMathurin opened this issue Mar 15, 2024 · 0 comments

Comments

@RemDelaporteMathurin
Copy link
Collaborator

In Task 6, we are using mobile.solution this is equivalent to mobile.mobile_concentration() when we don't account for conservation of chemical potential, but isn't otherwise.

To avoid confusion when users try to adapt this to a multi-mterial case, we should use .mobile_concentration()

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant