factors: Add basic CI #2664
Merged
factors: Add basic CI #2664
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a temporary hack while the factors branch CI is broken during refactoring. Signed-off-by: Lann Martin <[email protected]>
rylev
approved these changes
Jul 19, 2024
| @@ -1,5 +1,5 @@ | |||
| fn main() { | |||
| println!("cargo::rerun-if-changed=build.rs"); | |||
| println!("cargo:rerun-if-changed=build.rs"); | |||
There was a problem hiding this comment.
If this line necessary? I believe I commented before that build.rs files automatically build if they're modified, but I'm not sure what the response to that was.
There was a problem hiding this comment.
If you emit nothing then it rebuilds on any file changing.
There was a problem hiding this comment.
Ah - I had somehow completely forgotten that that's the case...
lann
force-pushed
the
factors-tests
branch
2 times, most recently
from
96f5932
to
384255a
Compare
Signed-off-by: Lann Martin <[email protected]>
Signed-off-by: Lann Martin <[email protected]>
Signed-off-by: Lann Martin <[email protected]>
|
I gave up on getting spin-core tests passing in CI. YOU WIN THIS TIME GITHUB ACTIONS |
Signed-off-by: Lann Martin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.