Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace async-tar dependency #2846

Open
rylev opened this issue Sep 19, 2024 · 1 comment · Fixed by #2862
Open

Replace async-tar dependency #2846

rylev opened this issue Sep 19, 2024 · 1 comment · Fixed by #2862

Comments

@rylev
Copy link
Collaborator

rylev commented Sep 19, 2024

We're currently relying on a fork of async-tar - it seems because of previous Windows build failures. It would be best to replace this dependency with a more maintained version. Ideally we would replace async-tar entirely as it is currently the only dependency bringing in async-std which itself has ~5 dependencies we don't otherwise use. It might make sense to switch to the sync tar crate and use tokio::sync::spawn_blocking where appropriate.

@itowlson
Copy link
Contributor

We are now back on official async-tar but the broader issue about async-std remains.

@itowlson itowlson reopened this Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants