Allow gchat login page #403
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SpecialAro
requested changes
Aug 23, 2023
There was a problem hiding this comment.
Tested and LGTM!
@iconeb, would you please bump the package.json version to 1.8.0 ? This way, users will be notified to upgrade to the new recipe version.
Thank you very much!
|
Also, I think this PR closes ferdium/ferdium-app#1323 |
2 tasks
SpecialAro
force-pushed
the
gchat-login-page
branch
from
a8b3105
to
44f6ca1
Compare
SpecialAro
approved these changes
Aug 23, 2023
|
@vraravam looks like the build is failing but the version bump is ok. I dont see any errors on my local when running
|
|
yes, this kind of flakiness has occurred in the past. lets merge |
Add reference to workspace.google.com to redirect to login page
vraravam
force-pushed
the
gchat-login-page
branch
from
263bdc7
to
4e90406
Compare
|
Linter found some issues - I have added a new commit to this PR @iconeb - please follow instructions to ensure that the PR is complete and correct. Thanks for your contribution |
|
@all-contributors - please add @iconeb for code |
|
I've put up a pull request to add @iconeb! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre-flight Checklist
Please ensure you've completed all of the following.
Description of Change
Add reference to workspace.google.com to redirect to login page, similar to other google services like Calendar and Mail