This repository has been archived by the owner on Apr 17, 2023. It is now read-only.
Race condition improved #57
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wtrocki
commented
Dec 19, 2019
| @@ -154,8 +154,10 @@ function upsertOrDeleteDatasetRecords(datasetId, datasetClientId, records, cb) { | |||
| } else if (op === 'delete') { | |||
| //remove the ref | |||
| update['$pull'] = {'refs': datasetClientId}; | |||
| // also set the hash to null to handle race condition when multiple refs associated with single record | |||
| update['$set']['hash'] = null; | |||
| if(datasetClientId && datasetClientId.length !==0){ | |||
There was a problem hiding this comment.
Actually this is still quite bad. Technically we should be
A) Removing an item if there is no other ref
B) Removing just ref if there are other refs
Not sure if that is not going to cause and side issues
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More refined version of the fix that was applied.
Refinement based on the problem from #48