Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update packit config #121

Merged
merged 1 commit into from
Oct 11, 2023
Merged

Conversation

nullr0ute
Copy link
Member

Update packit configs to build all current Fedora
releases so we don't need to update this file.

Update packit configs to build all current Fedora
releases so we don't need to update this file.

Signed-off-by: Peter Robinson <[email protected]>
Copy link
Member

@LorbusChris LorbusChris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pcdubs
Copy link
Member

pcdubs commented Oct 11, 2023

LGTM

@7flying
Copy link
Member

7flying commented Oct 11, 2023

Are the "testing-farm:fedora-37-x86_64 — Test job requires build job definition in the configuration." warnings on the Github CI thing something expected?

@pcdubs pcdubs merged commit dcad23a into fedora-iot:main Oct 11, 2023
7 checks passed
@LorbusChris
Copy link
Member

@7flying expected no, but this change shouldn't affect the pre-commit tests at all. Idk, maybe a packit limitation when the config file is touched? Should see on other PRs whether this persists..

@7flying
Copy link
Member

7flying commented Oct 11, 2023

@7flying expected no, but this change shouldn't affect the pre-commit tests at all. Idk, maybe a packit limitation when the config file is touched? Should see on other PRs whether this persists..

Good point, let's wait and see

@lachmanfrantisek
Copy link

Are the "testing-farm:fedora-37-x86_64 — Test job requires build job definition in the configuration." warnings on the Github CI thing something expected?

@LorbusChris @7flying @nullr0ute Hello! The information is correct.

By default, the test job requires a Copr build job so the RPMs are installed in the VM where the tests are run. (We currently don't support the Koji build with tests -- please, open a new issue if you think this should be implemented)

You can either define a new Copr build:

  - job: copr_build
    trigger: pull_request
    targets:
      - fedora-all

Or, if you don't need the build and want to run just tests, you can use skip_build option for tests to run just tests.

And one note about test definition:

  • If there are TMT tests in the repo, they are used.
  • If no, we run a default installability check. (That does not make much sense when skipping the build.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants