Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update agent.py to call loop.create_task rather than asyncio.Task #550

Closed
wants to merge 5 commits into from
Closed

Update agent.py to call loop.create_task rather than asyncio.Task #550

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
144cb5f
Update agent.py to call loop.create_task rather than asyncio.Task
wbarnha Sep 29, 2023
1d9400b
Update agent.py
wbarnha Sep 29, 2023
5a1580b
Merge branch 'master' into use-create-task
wbarnha Sep 29, 2023
166cb07
Fix linting in agent.py
wbarnha Sep 29, 2023
550a432
Merge branch 'master' into use-create-task
wbarnha Dec 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion faust/agents/agent.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -661,7 +661,9 @@ async def _prepare_actor(self, aref: ActorRefT, beacon: NodeT) -> ActorRefT:
else:
# agent yields and is an AsyncIterator so we have to consume it.
coro = self._slurp(aref, aiter(aref))
task = asyncio.Task(self._execute_actor(coro, aref), loop=self.loop)
# Calling asyncio.Task is not proper usage of asyncio,
# we need to create the task directly from the loop
task = self.loop.create_task(self._execute_actor(coro, aref))
task._beacon = beacon # type: ignore
aref.actor_task = task
self._actors.add(aref)
Expand Down
Loading