You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
However, faust does not implement on_clear at all.
This means that the in-memory data structure is cleared but the change is not reflected in the changelog topic. Upon recovery elements that were previously cleared may re-appear. I think the fix would be very simple:
mode
has a method to clear all the elements in a set (https://github.com/faust-streaming/mode/blob/c0aa58181432402dca30aa5978179383863a185a/mode/utils/collections.py#L546-L548) which calls an.on_clear
callback.This
.on_clear
callback method is empty by default (https://github.com/faust-streaming/mode/blob/c0aa58181432402dca30aa5978179383863a185a/mode/utils/collections.py#L535-L536)However,
faust
does not implementon_clear
at all.This means that the in-memory data structure is cleared but the change is not reflected in the changelog topic. Upon recovery elements that were previously cleared may re-appear. I think the fix would be very simple:
faust/faust/tables/sets.py
Lines 34 to 36 in 4a09533
on_clear
similar tofaust/faust/tables/sets.py
Lines 77 to 78 in 4a09533
maybe setting the value to a tombstone?
faust/faust/tables/sets.py
Lines 95 to 111 in 4a09533
The text was updated successfully, but these errors were encountered: