Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: follow updates on fastify #638

Closed
wants to merge 1 commit into from
Closed

Conversation

is2ei
Copy link
Contributor

@is2ei is2ei commented Jul 1, 2023

Fixed the failed tests.
Fastify updates find-my-way version and it looks the outputs are changed.
fastify/fastify@eafeed7

Checklist

@is2ei
Copy link
Contributor Author

is2ei commented Jul 1, 2023

Could anyone re-run the failed test?
I guess I fixed the failed test but timing issue may occur.
e.g. https://github.com/fastify/fastify-cli/actions/runs/4869067221/jobs/8683150011

@bcomnes
Copy link
Contributor

bcomnes commented Jul 20, 2023

I managed to fix the failing tests in #639 though I still want to look into the watch tests I added skips for to either make those work more reliably on macOS or specify they are written with linux only assumptions.

@is2ei is2ei closed this Jul 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants