composedPlugin should have its own prefix context #368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jean-michelet
changed the title
|
Could you please merge from main? I think the tests will now pass. |
2 tasks
2 tasks
climba03003
added a commit
that referenced
this pull request
Jun 17, 2024
This reverts commit c1685f4.
4 tasks
jean-michelet
pushed a commit
that referenced
this pull request
Jun 17, 2024
This reverts commit c1685f4.
jean-michelet
added a commit
that referenced
this pull request
Jun 17, 2024
…)"" This reverts commit 65c3dd1.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #326
Currently, when autohooks are involved, we observe unexpected behavior, such as
setNotFoundHandlerassociated with the root/prefix even though it is defined in a child folder with its own prefix. This prevents custom configuration ofsetNotFoundHandlerby child and sibling plugins.It appears that plugins involving autohooks are composed in a parent plugin, I think that's when the prefix context is lost:
fastify-autoload/index.js
Line 103 in e107d5b
Not sure howsetNotFoundHandleris associated with root prefix when defined in a child plugin but I guess it has something to do withskip-overrideconfigured for hookPlugins?In this PR, I propose to pass the prefix option to the composed plugin, but I'm not sure this is the expected behavior, wdyt?