Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(shuttle): Shuttle should rewind a few seconds in the event stream on restart #2172

Open
sanjayprabhu opened this issue Jul 12, 2024 · 1 comment
Labels
help wanted Well specified and ready to be worked on s-triage Needs to be reviewed, designed and prioritized t-feat Add a new feature or protocol improvement

Comments

@sanjayprabhu
Copy link
Contributor

What is the feature you would like to implement?
Shuttle resumes from the last saved event id always. But sometimes it's possible for events to be emitted out of order. To be safe, it should rewind a small number of seconds (1-5?) from the most recent event id when it resumes after a restart. We could make this configurable.

Why is this feature important?
An argument for why this feature should be built and how it should be prioritized

Will the protocol spec need to be updated??
Call out the sections of the protocol spec that will need to be updated (e.g. Section 4.3 - Verifications, Section 3.1 - Identity Systems)

How should this feature be built? (optional)
A design for the implementation of the feature

Additional context
Add any other context or screenshots about the feature request here.

@sanjayprabhu sanjayprabhu added help wanted Well specified and ready to be worked on t-feat Add a new feature or protocol improvement labels Jul 12, 2024
@github-actions github-actions bot added the s-triage Needs to be reviewed, designed and prioritized label Jul 12, 2024
@Rufusemmanuel
Copy link

I think I once talked about this and it should be treated with urgency

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Well specified and ready to be worked on s-triage Needs to be reviewed, designed and prioritized t-feat Add a new feature or protocol improvement
Projects
None yet
Development

No branches or pull requests

2 participants