Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Program ReactiveFacileDataStore implementation up to FacileDataStore API #3

Open
lianos opened this issue Mar 2, 2020 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@lianos
Copy link
Member

lianos commented Mar 2, 2020

Currently we have an assumption that this is wrapping a FacileDataSet.

ReactiveFacileDataStore() and the chain of functions it delegates to that support it (filteredReactiveFacileDataStore() and reactiveFacileDataStore()) assume we are only working with FacileDataSets, which are loaded from the path on disk.

Now that we have FacileBiocData, we need to program up to the general FacileDataStore API so that they can be used as data providers to the shiny bits.

You'll know you've almost got it when this FacileAnalysis mojo work:

  1. samples(FacileBiocDataStore) %>% fpca() %>% shine()
  2. fpcaGadget(FacileBiocDataStore)
  3. fdgeGadget(FacileBiocDataStore)
@lianos lianos added the enhancement New feature or request label Mar 2, 2020
@lianos lianos self-assigned this Mar 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant