Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Evaluation on public dataset #94

Open
Blank-z0 opened this issue Oct 11, 2024 · 0 comments
Open

Evaluation on public dataset #94

Blank-z0 opened this issue Oct 11, 2024 · 0 comments

Comments

@Blank-z0
Copy link

Hi, great work!
I'm trying to reproduce the results on public datasets. However, I only found the training codes, where the model was evaluated on the eval set (or you don't use train/eval/test spilt, only train/test split?). I’d like to know if you partitioned the public dataset into a test set, and whether the results reported in the paper correspond to the test set or the eval set.
If I want to partition a test set, should I set ignore_last_n=0,1,2 when loading the test, eval and train dataset? For example:

train_dataset = DatasetV2(
      ratings_file=dp.output_format_csv(),
      padding_length=max_sequence_length + 1,  # target
      ignore_last_n=2,
      chronological=chronological,
)
eval_dataset = DatasetV2(
      ratings_file=dp.output_format_csv(),
      padding_length=max_sequence_length + 1,  # target
      ignore_last_n=1,
      chronological=chronological,
)
test_dataset = DatasetV2(
      ratings_file=dp.output_format_csv(),
      padding_length=max_sequence_length + 1,  # target
      ignore_last_n=0,
      chronological=chronological,
)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant