Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inquiry regarding the yaw range of images in the MGL dataset #20

Open
wangerniuniu opened this issue Aug 12, 2023 · 1 comment
Open

Comments

@wangerniuniu
Copy link

During my usage, I noticed that the yaw range of the images is defined as -360° to 360°, rather than the conventional 0° to 360° range. I am perplexed by this design decision and would like to understand the reasoning behind it.

Could you kindly explain why you chose to define the yaw angle within the range of -360° to 360°? Are there any specific technical or practical requirements that led to this setting? Furthermore, what implications does this variation have on data processing and analysis compared to the traditional 0° to 360° range?

@sarlinpe
Copy link
Collaborator

The yaw predicted by OrienterNet should be in [0, 360°]:

angle_index = indices % num_rotations
angle = angle_index * 360 / num_rotations

GT data may be stored with a different range, but it doesn't matter because it is shifted to the same one when computing the evaluation error:
def angle_error(t, t_gt):
error = torch.abs(t % 360 - t_gt.to(t) % 360)
error = torch.minimum(error, 360 - error)
return error

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants