Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to switch from "single-frame mode" to "sequence mode" in this project? #10

Open
carrroo opened this issue Jul 18, 2023 · 7 comments

Comments

@carrroo
Copy link

carrroo commented Jul 18, 2023

Hello, the paper pointed out that the accuracy of the image sequence is higher, so how to switch from "single-frame mode" to "sequence mode" in this project?
:) Thanks!

@carrroo carrroo closed this as not planned Won't fix, can't repro, duplicate, stale Jul 18, 2023
@carrroo carrroo reopened this Jul 18, 2023
@carrroo
Copy link
Author

carrroo commented Jul 18, 2023

I tried to replace the file name in the "test2_files.txt" with a sequence of images, however the accuracy didn't seem to improve

@sarlinpe
Copy link
Collaborator

From the README:

To run the evaluation in sequential mode (by default with 10 frames):
python -m maploc.evaluation.mapillary [...] --sequential

maploc.evaluation.kitti has the same flag. The maximum number of frames per segment can be updated with:

python -m maploc.evaluation.mapillary [...] --sequential chunking.max_length=20

I have updated the README accordingly.

@carrroo
Copy link
Author

carrroo commented Jul 18, 2023

I saw the parameter configuration in "kitti.py" just recently, appreciate your reply

@carrroo carrroo closed this as completed Jul 18, 2023
@carrroo
Copy link
Author

carrroo commented Jul 18, 2023

File "/home/zj/OrienterNet/maploc/data/sequential.py", line 18, in chunk_sequence
sort_array = data.get("capture_time", data.get("index", names or indices))
ValueError: The truth value of an array with more than one element is ambiguous. Use a.any() or a.all()

After I add the "--sequential" flag, it still doesn't seem to work.
Is sequential mode not suitable for KITTI?

@carrroo carrroo reopened this Jul 18, 2023
@sarlinpe
Copy link
Collaborator

Pushed a fix in 213aff4.

@carrroo
Copy link
Author

carrroo commented Jul 19, 2023

Thank you very much for your reply!
I noticed that the function plot_example_sequential is not implemented, will sequential mode support visual export in the future?

@sarlinpe
Copy link
Collaborator

Yes, this is WIP in this notebook. I'll add code to generate sequential animations when I find the time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants