Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deployment fixes for web app build #640

Draft
wants to merge 8 commits into
base: development
Choose a base branch
from

Conversation

s0mya
Copy link

@s0mya s0mya commented Mar 28, 2022

Fixes #{issue number}

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 28, 2022
@codecov-commenter
Copy link

codecov-commenter commented Mar 28, 2022

Codecov Report

Merging #640 (6b2e038) into development (6cf4926) will decrease coverage by 0.09%.
The diff coverage is n/a.

@@               Coverage Diff               @@
##           development     #640      +/-   ##
===============================================
- Coverage        88.50%   88.40%   -0.10%     
===============================================
  Files              115      115              
  Lines             7066     7066              
===============================================
- Hits              6254     6247       -7     
- Misses             812      819       +7     
Impacted Files Coverage Δ
compiler_gym/util/tabulate.py 50.00% <0.00%> (-7.15%) ⬇️
compiler_gym/util/executor.py 74.43% <0.00%> (-3.41%) ⬇️
...loop_tool/service/loop_tool_compilation_session.py 87.75% <0.00%> (-2.05%) ⬇️
compiler_gym/service/connection.py 78.03% <0.00%> (-0.99%) ⬇️
compiler_gym/envs/gcc/service/gcc_service.py 97.06% <0.00%> (+0.36%) ⬆️
compiler_gym/envs/compiler_env.py 89.78% <0.00%> (+0.47%) ⬆️
compiler_gym/util/download.py 95.52% <0.00%> (+1.49%) ⬆️
compiler_gym/views/observation.py 100.00% <0.00%> (+2.70%) ⬆️
compiler_gym/views/observation_space_spec.py 84.84% <0.00%> (+3.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6cf4926...6b2e038. Read the comment docs.

@ChrisCummins
Copy link
Contributor

Hi @s0mya, is this still WIP?

@s0mya
Copy link
Author

s0mya commented Apr 25, 2022

Hi @s0mya, is this still WIP?

HI @ChrisCummins, yes I think we're still working through this to test it out for prod.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants