Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Run main tests with torchrl nightly and have a separate CI for testing torchrl stable #53

Merged
merged 9 commits into from
Feb 1, 2024

Conversation

matteobettini
Copy link
Collaborator

@matteobettini matteobettini commented Jan 19, 2024

BenchMARL development is based on torchrl nightly. In the same way that torchrl is based on tensordict.

In this PR we add a CI to test against torchrl stable as well.

In the current stage, this CI skips GNN tests as torch_geometric is not supperted in any torchrl stable version as of now

cc @vmoens

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 19, 2024
@matteobettini matteobettini added the smacv2 Label to be assigned to run the SMACv2 tests label Jan 19, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jan 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6cac0c2) 89.73% compared to head (ff57eef) 87.03%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #53      +/-   ##
==========================================
- Coverage   89.73%   87.03%   -2.70%     
==========================================
  Files          64       69       +5     
  Lines        2669     2731      +62     
==========================================
- Hits         2395     2377      -18     
- Misses        274      354      +80     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@matteobettini matteobettini changed the title [CI] Run main tests with torchrl stable and have a separate CI for testing torchrl nightly [CI] Run main tests with torchrl nightly and have a separate CI for testing torchrl stable Jan 19, 2024
@matteobettini matteobettini marked this pull request as draft January 19, 2024 13:23
@matteobettini matteobettini marked this pull request as ready for review February 1, 2024 14:46
@matteobettini matteobettini merged commit ca33835 into main Feb 1, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. smacv2 Label to be assigned to run the SMACv2 tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants