Create mutable variable store #514
Closed
+35
−19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RoboticPrism
requested review from
d3sch41n,
cedowens,
d0n601 and
CrimsonK1ng
as code owners
|
This pull request was exported from Phabricator. Differential Revision: D63457210 |
Summary: Pull Request resolved: facebookincubator#514 Create a variable store that we can mutate between test steps. Move WorkDir into this variable store so that we can mutate the work dir for a future cd step. In the future if we want to carry any other information between steps in a mutable fashion, all we need to do is add a new variable to this struct. Reviewed By: inesusvet Differential Revision: D63457210
|
This pull request was exported from Phabricator. Differential Revision: D63457210 |
RoboticPrism
force-pushed
the
export-D63457210
branch
from
052aade
to
904422a
Compare
|
This pull request has been merged in 1b645b8. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Create a variable store that we can mutate between test steps. Move WorkDir into this variable store so that we can mutate the work dir for a future cd step.
In the future if we want to carry any other information between steps in a mutable fashion, all we need to do is add a new variable to this struct.
Differential Revision: D63457210