This repository has been archived by the owner on Jun 12, 2018. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 17
/
rpool_test.go
554 lines (471 loc) · 11.1 KB
/
rpool_test.go
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
package rpool_test
import (
"errors"
"io"
"regexp"
"sync/atomic"
"testing"
"time"
"github.com/facebookgo/clock"
"github.com/facebookgo/ensure"
"github.com/facebookgo/rpool"
"github.com/facebookgo/stats"
)
var errWrongPool = errors.New("rpool: provided resource was not acquired from this pool")
type resource struct {
resourceMaker *resourceMaker
}
func (r *resource) Close() error {
atomic.AddInt32(&r.resourceMaker.closeCount, 1)
return nil
}
type resourceMaker struct {
newCount int32
closeCount int32
}
func (r *resourceMaker) New() (io.Closer, error) {
atomic.AddInt32(&r.newCount, 1)
return &resource{resourceMaker: r}, nil
}
type resourceCloseErr struct {
err error
}
func (r *resourceCloseErr) Close() error {
return r.err
}
func TestAcquireMakesANewResource(t *testing.T) {
t.Parallel()
var cm resourceMaker
p := rpool.Pool{
New: cm.New,
Max: 1,
MinIdle: 1,
IdleTimeout: time.Hour,
ClosePoolSize: 1,
}
r, err := p.Acquire()
ensure.Nil(t, err)
p.Release(r)
ensure.Nil(t, p.Close())
ensure.DeepEqual(t, atomic.LoadInt32(&cm.newCount), int32(1))
ensure.DeepEqual(t, atomic.LoadInt32(&cm.closeCount), int32(1))
}
func TestMax(t *testing.T) {
t.Parallel()
// we going to wait until stats shows we have 1 waiting acquire
statsDone := make(chan struct{})
doneWaiting := false
hc := &stats.HookClient{
BumpSumHook: func(key string, val float64) {
if !doneWaiting && key == "acquire.waiting" && val == 1 {
doneWaiting = true
close(statsDone)
}
},
}
var cm resourceMaker
p := rpool.Pool{
New: cm.New,
Stats: hc,
Max: 1,
MinIdle: 1,
IdleTimeout: time.Hour,
ClosePoolSize: 2,
}
// acquire and hold max
r, err := p.Acquire()
ensure.Nil(t, err)
// try to acquire again blocks
done := make(chan struct{})
go func() {
defer close(done)
r, err := p.Acquire()
ensure.Nil(t, err)
p.Release(r)
}()
// stats should soon show one waiting
<-statsDone
// release the first one
p.Release(r)
ensure.Nil(t, p.Close())
<-done
ensure.DeepEqual(t, atomic.LoadInt32(&cm.newCount), int32(1))
ensure.DeepEqual(t, atomic.LoadInt32(&cm.closeCount), int32(1))
}
func TestUseIdle(t *testing.T) {
t.Parallel()
// expected stats
statsDone := make(chan struct{})
hc := &stats.HookClient{
BumpSumHook: func(key string, val float64) {
if key == "acquire.pool" {
close(statsDone)
}
},
}
var cm resourceMaker
p := rpool.Pool{
New: cm.New,
Stats: hc,
Max: 1,
MinIdle: 1,
IdleTimeout: time.Hour,
ClosePoolSize: 2,
}
// acquire and release
r1, err := p.Acquire()
ensure.Nil(t, err)
p.Release(r1)
// acquire should use the existing one
r2, err := p.Acquire()
ensure.Nil(t, err)
p.Release(r2)
<-statsDone
ensure.Nil(t, p.Close())
ensure.DeepEqual(t, atomic.LoadInt32(&cm.newCount), int32(1))
ensure.DeepEqual(t, atomic.LoadInt32(&cm.closeCount), int32(1))
}
func TestNewError(t *testing.T) {
t.Parallel()
// expected stats
statsDone := make(chan struct{})
hc := &stats.HookClient{
BumpSumHook: func(key string, val float64) {
if key == "acquire.error.new" {
close(statsDone)
}
},
}
expected := errors.New("")
p := rpool.Pool{
New: func() (io.Closer, error) { return nil, expected },
Stats: hc,
Max: 1,
MinIdle: 1,
IdleTimeout: time.Hour,
ClosePoolSize: 2,
}
r, actual := p.Acquire()
ensure.Nil(t, r)
ensure.DeepEqual(t, actual, expected)
ensure.Nil(t, p.Close())
<-statsDone
}
func TestAcquireAfterClose(t *testing.T) {
t.Parallel()
// expected stats
statsDone := make(chan struct{})
hc := &stats.HookClient{
BumpSumHook: func(key string, val float64) {
if key == "acquire.error.closed" {
close(statsDone)
}
},
}
var cm resourceMaker
p := rpool.Pool{
New: cm.New,
Stats: hc,
Max: 1,
MinIdle: 1,
IdleTimeout: time.Hour,
ClosePoolSize: 2,
}
// acquire and hold max
r1, err := p.Acquire()
ensure.Nil(t, err)
// close in two goroutines, one of them should error
closeError := make(chan error, 1)
closeDone1 := make(chan struct{})
closeDone2 := make(chan struct{})
go func() {
defer close(closeDone1)
if err := p.Close(); err != nil {
closeError <- err
}
}()
go func() {
defer close(closeDone2)
if err := p.Close(); err != nil {
closeError <- err
}
}()
ensure.Err(t, <-closeError, regexp.MustCompile("Pool.Close called more than once"))
// acquire now fails
r2, err := p.Acquire()
ensure.Nil(t, r2)
ensure.Err(t, err, regexp.MustCompile("pool has been closed"))
p.Release(r1)
// both close should be done now
<-closeDone1
<-closeDone2
<-statsDone
ensure.DeepEqual(t, atomic.LoadInt32(&cm.newCount), int32(1))
ensure.DeepEqual(t, atomic.LoadInt32(&cm.closeCount), int32(1))
}
func TestMaxAndDiscard(t *testing.T) {
t.Parallel()
// we going to wait until stats shows we have 1 waiting acquire
statsDone := make(chan struct{})
doneWaiting := false
hc := &stats.HookClient{
BumpSumHook: func(key string, val float64) {
if !doneWaiting && key == "acquire.waiting" && val == 1 {
doneWaiting = true
close(statsDone)
}
},
}
var cm resourceMaker
p := rpool.Pool{
New: cm.New,
Stats: hc,
Max: 1,
MinIdle: 1,
IdleTimeout: time.Hour,
ClosePoolSize: 2,
}
// acquire and hold max
r, err := p.Acquire()
ensure.Nil(t, err)
// try to acquire again blocks
done := make(chan struct{})
go func() {
defer close(done)
r, err := p.Acquire()
ensure.Nil(t, err)
p.Release(r)
}()
// stats should soon show one waiting
<-statsDone
// discard the first one
p.Discard(r)
ensure.Nil(t, p.Close())
<-done
ensure.DeepEqual(t, atomic.LoadInt32(&cm.newCount), int32(2))
ensure.DeepEqual(t, atomic.LoadInt32(&cm.closeCount), int32(2))
}
func TestCloseErrorHandler(t *testing.T) {
t.Parallel()
// expected stats
statsDone := make(chan struct{})
hc := &stats.HookClient{
BumpSumHook: func(key string, val float64) {
if key == "close.error" {
close(statsDone)
}
},
}
done := make(chan struct{})
expected := errors.New("")
p := rpool.Pool{
New: func() (io.Closer, error) {
return &resourceCloseErr{err: expected}, nil
},
CloseErrorHandler: func(actual error) {
defer close(done)
ensure.DeepEqual(t, actual, expected)
},
Stats: hc,
Max: 1,
MinIdle: 1,
IdleTimeout: time.Hour,
ClosePoolSize: 1,
}
r, err := p.Acquire()
ensure.Nil(t, err)
p.Release(r)
ensure.Nil(t, p.Close())
<-done
<-statsDone
}
func TestDoublePoolClose(t *testing.T) {
t.Parallel()
var cm resourceMaker
p := rpool.Pool{
New: cm.New,
Max: 1,
MinIdle: 1,
IdleTimeout: time.Hour,
ClosePoolSize: 2,
}
// acquire and hold
r1, err := p.Acquire()
ensure.Nil(t, err)
// close in two goroutines, one of them should error
closeError := make(chan error, 1)
closeDone1 := make(chan struct{})
closeDone2 := make(chan struct{})
go func() {
defer close(closeDone1)
if err := p.Close(); err != nil {
closeError <- err
}
}()
go func() {
defer close(closeDone2)
if err := p.Close(); err != nil {
closeError <- err
}
}()
ensure.Err(t, <-closeError, regexp.MustCompile("Pool.Close called more than once"))
// release original resource
p.Release(r1)
// both close should be done now
<-closeDone1
<-closeDone2
ensure.DeepEqual(t, atomic.LoadInt32(&cm.newCount), int32(1))
ensure.DeepEqual(t, atomic.LoadInt32(&cm.closeCount), int32(1))
}
func TestIdleClose(t *testing.T) {
t.Parallel()
const (
max = 5
minIdle = 2
)
klock := clock.NewMock()
// we going to wait until stats shows we closed enough idle
statsDone := make(chan struct{})
expectedIdleClosed := int32(max - minIdle)
hc := &stats.HookClient{
BumpSumHook: func(key string, val float64) {
if key == "idle.closed" {
if atomic.AddInt32(&expectedIdleClosed, -int32(val)) == 0 {
close(statsDone)
}
}
},
}
var cm resourceMaker
p := rpool.Pool{
New: cm.New,
Stats: hc,
Max: max,
MinIdle: minIdle,
IdleTimeout: time.Second,
ClosePoolSize: 2,
Clock: klock,
}
// acquire and release some resources to make them idle
var resources []io.Closer
for i := max; i > 0; i-- {
r, err := p.Acquire()
ensure.Nil(t, err)
resources = append(resources, r)
}
// this will be used as the "last use" time
klock.Add(p.IdleTimeout / 2)
for _, r := range resources {
p.Release(r)
}
// tick another IdleTimeout / 2 to hit the 0 eligible case
klock.Add(p.IdleTimeout / 2)
// tick another IdleTimeout to make them eligible
klock.Add(p.IdleTimeout)
// stats should soon show idle closed
<-statsDone
// tick another IdleTimeout to hit the eligibleOffset check
klock.Add(p.IdleTimeout)
ensure.Nil(t, p.Close())
ensure.DeepEqual(t, atomic.LoadInt32(&cm.newCount), int32(max))
ensure.DeepEqual(t, atomic.LoadInt32(&cm.closeCount), int32(max))
}
func TestReleaseInvalid(t *testing.T) {
t.Parallel()
defer ensure.PanicDeepEqual(t, errWrongPool)
var cm resourceMaker
p := rpool.Pool{
New: cm.New,
Max: 1,
MinIdle: 1,
IdleTimeout: time.Hour,
ClosePoolSize: 1,
}
r, err := cm.New()
ensure.Nil(t, err)
p.Release(r)
}
func TestDiscardInvalid(t *testing.T) {
t.Parallel()
defer ensure.PanicDeepEqual(t, errWrongPool)
var cm resourceMaker
p := rpool.Pool{
New: cm.New,
Max: 1,
MinIdle: 1,
IdleTimeout: time.Hour,
ClosePoolSize: 1,
}
r, err := cm.New()
ensure.Nil(t, err)
p.Discard(r)
}
func TestMaxUndefined(t *testing.T) {
t.Parallel()
defer ensure.PanicDeepEqual(t, "no max configured")
(&rpool.Pool{}).Acquire()
}
func TestIdleTimeoutUndefined(t *testing.T) {
t.Parallel()
defer ensure.PanicDeepEqual(t, "no idle timeout configured")
(&rpool.Pool{Max: 1}).Acquire()
}
func TestClosePoolSizeUndefined(t *testing.T) {
t.Parallel()
defer ensure.PanicDeepEqual(t, "no close pool size configured")
(&rpool.Pool{
Max: 1,
IdleTimeout: time.Second,
}).Acquire()
}
func TestStatsTicker(t *testing.T) {
t.Parallel()
klock := clock.NewMock()
expected := []string{"alive", "idle", "out", "waiting"}
statsDone := make(chan string, 4)
hc := &stats.HookClient{
BumpAvgHook: func(key string, val float64) {
if contains(expected, key) {
statsDone <- key
}
},
}
var cm resourceMaker
p := rpool.Pool{
New: cm.New,
Stats: hc,
Max: 4,
MinIdle: 2,
IdleTimeout: time.Second,
ClosePoolSize: 2,
Clock: klock,
}
// acquire and release some resources to make them idle
var resources []io.Closer
for i := p.Max; i > 0; i-- {
r, err := p.Acquire()
ensure.Nil(t, err)
resources = append(resources, r)
}
for _, r := range resources {
p.Release(r)
}
// tick IdleTimeout to make them eligible
klock.Add(p.IdleTimeout)
// tick Minute to trigger stats
klock.Add(time.Minute)
// stats should soon show idle closed
ensure.SameElements(
t,
[]string{<-statsDone, <-statsDone, <-statsDone, <-statsDone},
expected,
)
}
func contains(set []string, key string) bool {
for _, v := range set {
if v == key {
return true
}
}
return false
}