[compiler] Allow ReactElement symbol to be configured when inlining jsx #30996
+28
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
facebook-github-bot
added
CLA Signed
React Core Team
kassens
approved these changes
Sep 18, 2024
| */ | ||
| enableInlineJsxTransform: z.boolean().default(false), | ||
| inlineJsxTransform: ReactElementSymbolSchema.nullish(), |
There was a problem hiding this comment.
this format of a nullable string makes it harder or uglier to add more options in the future w/o breaking changes. You could consider a nullable object with a elementSymbol key.
If it's only for internal experimentation, it doesn't really matter that much.
jackpope
force-pushed
the
inline-jsx-3
branch
from
6b83edc
to
f4d3cee
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #30995 (rendered diff)
Some apps still use
react.elementsymbols. Not only do we want to test there but we also want to be able to upgrade those sites toreact.transitional.elementwithout blocking on the compiler (we can change the symbol feature flag and compiler config at the same time).The compiler runtime uses
react.transitional.element, so the snap fixture will fail if we change the default here. However I confirmed that commenting out the fixture entrypoint and running snap withreact.elementwill update the fixture symbols as expected.