fix: FormData filename in content-disposition

[foyarash]

Summary:

This Pull Request fixes a regression introduced in 7c7e9e6, which adds a filename* attribute to the content-disposition of a FormData part. However, as the MDN states, there is no filename* attribute for the content-disposition header in case of a form data.

The filename* attribute would break the parsing of form data in the request, such as in frameworks like Next.js which uses the web implementation of Request.

Fixes #44737

Changelog:

[General] [Fixed] - Remove non compliant filename* attribute in a FormData content-disposition header

Test Plan:

• Clone the react-native repo
• Create a simple JS file that will act as a node server and execute it

const http = require('http');

const server = http.createServer(async function (r, res) {
    const req = new Request(new URL(r.url, 'http://localhost:3000'), {
      headers: r.headers,
      method: r.method,
      body: r,
      duplex: 'half',
    });

    const fileData = await req.formData();

    console.log(fileData);
    res.writeHead(200);
    res.end();
});
server.listen(3000);

• Go to packages/rn-tester
• Add a useEffect in js/RNTesterAppShared.js

React.useEffect(() => {
    const formData = new FormData();
    formData.append('file', {
      uri: 'https://www.gravatar.com/avatar',
      name: '测试photo/1.jpg',
      type: 'image/jpeg',
    });

    fetch('http://localhost:3000', {
      method: 'POST',
      body: formData,
    }).then(res => console.log(res.ok));
  });

• Run the app on iOS or Android
• The node server should output the file added to the FormData with an encoded name

[facebook-github-bot]

Hi @foyarash!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

[facebook-github-bot]

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!