Changed the except to have OSError instead of Exception #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @benwei13 , can you please look into this. |
facebook-github-bot
pushed a commit
that referenced
this pull request
Aug 20, 2019
Summary: As title Pull Request resolved: facebookexternal/openbmc.celestica#104 Reviewed By: tomrepo fbshipit-source-id: cda1b58ffa
bbinxie
pushed a commit
to SW-CSA/openbmc
that referenced
this pull request
Aug 29, 2019
Summary: SIM led may not change in time if interval(0) - 1 = 255. Pull Request resolved: facebookexternal/openbmc.accton#104 Test Plan: Build and verify on minipack system. Reviewed By: benwei13 fbshipit-source-id: 2d433ea30
There was a problem hiding this comment.
@williamspatrick has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
facebook-github-bot
pushed a commit
that referenced
this pull request
Jan 7, 2020
Summary: Pull Request resolved: #104 Reviewed By: amithash Pulled By: williamspatrick fbshipit-source-id: 897e426078
facebook-github-bot
pushed a commit
that referenced
this pull request
Nov 4, 2020
Summary: * ELBERT: Tune TH4 MAX6581 Temp sensor Tune Temp sensor on TH4 Diode accoring to HW measurements. This sensor is being moved to the dts of elbert instead of setup_i2c. - Resistance Cancellation register 0x4A = 0x03 - Transistor Ideality register 0x4B = 0x1F - Ideality Select register 0x4C = 0x03 root@bmc-oob:~# sensors max6581-i2c-4-4d max6581-i2c-4-4d Adapter: 1e78a280.i2c-bus SMB T: +29.6 C (high = +90.0 C, crit = +80.0 C) TH4 Die Temp 0: +35.9 C (high = +127.0 C, crit = +110.0 C) TH4 Die Temp 1: +35.8 C (high = +127.0 C, crit = +110.0 C) SMB R: +27.0 C (high = +100.0 C, crit = +127.0 C) SMB U: +27.8 C (high = +100.0 C, crit = +90.0 C) SMB L: +28.1 C (high = +100.0 C, crit = +90.0 C) * Moved TH4 MAX6581 to dts with tuned configs Pull Request resolved: facebookexternal/openbmc.arista#104 Test Plan: Imported from GitHub, without a `Test Plan:` line. Test in summary Reviewed By: mikechoifb fbshipit-source-id: a2d6a08102
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.