Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[lexical-yjs] init collabNode in nested composer with existing state #6368

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

ololoken
Copy link

@ololoken ololoken commented Jul 4, 2024

Description

When nested composer has state and connects to collab binding's collabNodeMap stays empty. As result synchronization with remote is not fired.

Copy link

vercel bot commented Jul 4, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lexical ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 13, 2024 4:17am
lexical-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 13, 2024 4:17am

@facebook-github-bot
Copy link
Contributor

Hi @ololoken!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

Copy link

github-actions bot commented Jul 4, 2024

size-limit report 📦

Path Size
lexical - cjs 28.5 KB (0%)
lexical - esm 28.31 KB (0%)
@lexical/rich-text - cjs 36.94 KB (0%)
@lexical/rich-text - esm 28.16 KB (0%)
@lexical/plain-text - cjs 35.59 KB (0%)
@lexical/plain-text - esm 25.46 KB (0%)
@lexical/react - cjs 38.82 KB (0%)
@lexical/react - esm 29.43 KB (0%)

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 4, 2024
@StyleT
Copy link
Contributor

StyleT commented Jul 11, 2024

Hi!

Can you pls elaborate on the issue? How to reproduce it now?

And would it be possible to cover fix with tests to prevent regression?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants