Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Use GITHUB_OUTPUT envvar instead of set-output command #5430

Closed
wants to merge 8 commits into from

Conversation

arunsathiya
Copy link

save-state and set-output commands used in GitHub Actions are deprecated and GitHub recommends using environment files.

This PR updates the usage of set-output to $GITHUB_OUTPUT

Instructions for envvar usage from GitHub docs:

https://docs.github.com/en/actions/using-workflows/workflow-commands-for-github-actions#setting-an-output-parameter

`save-state` and `set-output` commands used in GitHub Actions are deprecated and [GitHub recommends using environment files](https://github.blog/changelog/2023-07-24-github-actions-update-on-save-state-and-set-output-commands/).

This PR updates the usage of `set-output` to `$GITHUB_OUTPUT`

Instructions for envvar usage from GitHub docs:

https://docs.github.com/en/actions/using-workflows/workflow-commands-for-github-actions#setting-an-output-parameter
@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Jan 18, 2024
@passy
Copy link
Member

passy commented Jan 22, 2024

Thanks! I've been wanting to update that for a while!

@facebook-github-bot
Copy link
Contributor

@passy has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@arunsathiya has updated the pull request. You must reimport the pull request before landing.

@facebook-github-bot
Copy link
Contributor

@arunsathiya has updated the pull request. You must reimport the pull request before landing.

@arunsathiya
Copy link
Author

@passy One minor thing that had come to my notice: had to quote the envvar to retain spaces or special characters/treat as a single argument or value. It's done in 3dfa348. Sorry for any troubles!

@facebook-github-bot
Copy link
Contributor

@passy has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@passy
Copy link
Member

passy commented Jan 23, 2024

@arunsathiya It looks like something is still off for the Windows build. Could you take a look?

Copy link
Contributor

Pull Request Test Coverage Report for Build 7616232349

Warning: This coverage report may be inaccurate.

We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report.
To ensure accuracy in future PRs, please see these guidelines.
A quick fix for this PR: rebase it; your next report should be accurate.

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.02%) to 51.607%

Totals Coverage Status
Change from base Build 7611149134: -0.02%
Covered Lines: 8272
Relevant Lines: 14822

💛 - Coveralls

@facebook-github-bot
Copy link
Contributor

@arunsathiya has updated the pull request. You must reimport the pull request before landing.

@arunsathiya
Copy link
Author

It seems that Powershell commands need $env prefix, so this commit should help d8a5f2b, I believe. Watching this space to see how the build works out but it needs an approval first: https://github.com/facebook/flipper/actions/runs/7628655259

@facebook-github-bot
Copy link
Contributor

@arunsathiya has updated the pull request. You must reimport the pull request before landing.

@facebook-github-bot
Copy link
Contributor

@passy has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@passy
Copy link
Member

passy commented Jan 25, 2024

The windows runner still seems unhappy, unfortunately.

@facebook-github-bot
Copy link
Contributor

@arunsathiya has updated the pull request. You must reimport the pull request before landing.

@arunsathiya
Copy link
Author

I remember reviewing a bit two weeks but haven't gotten a chance to look again since.

I'll take another look soon but would like the latest checks to run once.

@facebook-github-bot
Copy link
Contributor

@arunsathiya has updated the pull request. You must reimport the pull request before landing.

@facebook-github-bot
Copy link
Contributor

@arunsathiya has updated the pull request. You must reimport the pull request before landing.

@facebook-github-bot
Copy link
Contributor

@passy has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@passy merged this pull request in 1c2fe52.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Do not delete this pull request or issue due to inactivity. Merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants