From 5ff667a28fec4b92c9d12a09f4355b0ddb47abbb Mon Sep 17 00:00:00 2001 From: Joshua Selbo Date: Fri, 19 Jul 2024 18:29:06 -0700 Subject: [PATCH] Drop SDK 19 tests (2) Summary: The next Robolectric release drops support for SDK 19 (KitKat). Nearly all apps are min SDK 21+ anyway. The strategy here: - If a test was explicitly designed to test a pre-21 code path, just remove it - If the test passes on the latest SDK, just remove the SDK-19 config - else, pin the test on SDK 21, punting the issue. Reviewed By: jiawei-lyu, xiphirx Differential Revision: D59983594 fbshipit-source-id: e12b660b3f9af4fb62a29265e7e4b80d7eacdb5d --- .../flipper/plugins/inspector/InspectorFlipperPluginTest.java | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/android/src/test/java/com/facebook/flipper/plugins/inspector/InspectorFlipperPluginTest.java b/android/src/test/java/com/facebook/flipper/plugins/inspector/InspectorFlipperPluginTest.java index 5ab13c00e00..9df7ceb0368 100644 --- a/android/src/test/java/com/facebook/flipper/plugins/inspector/InspectorFlipperPluginTest.java +++ b/android/src/test/java/com/facebook/flipper/plugins/inspector/InspectorFlipperPluginTest.java @@ -42,7 +42,7 @@ @LooperMode(LEGACY) @RunWith(RobolectricTestRunner.class) -@Config(sdk = 19) +@Config(sdk = 21) public class InspectorFlipperPluginTest { private MockApplicationDescriptor mApplicationDescriptor; @@ -297,7 +297,7 @@ protected NodeDescriptor descriptorForObject(Object obj) { .put("1", new FlipperObject.Builder())))) .put( "path", - new FlipperArray.Builder().put("com.facebook.flipper").put("test").put("1")) + new FlipperArray.Builder().put("com.facebook.flipper").put("test").put("3")) .build())); }