Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Roots-review #29

Open
tess-phillips opened this issue Nov 8, 2023 · 1 comment
Open

Roots-review #29

tess-phillips opened this issue Nov 8, 2023 · 1 comment

Comments

@tess-phillips
Copy link

Live laugh love the background and carousels of the main page

No husky :(
Lots of css files, why u no use tailwind only? interesting
love that you have jest installed for unit testing. if you want to install playwright i can help (also you may need to tell jest to only look at jest and same for playwright, https://playwright.dev/docs/intro this link is waaaay better than the next installation guide)

@sgroi-l
Copy link

sgroi-l commented Nov 8, 2023

Hey gang, this look like it's gonna be sick. I have nothing interesting to tell you sorry, it looks like you haven't set up your eslintrc.json to have anything other than default values and you don't have prettier to enforce anything either.

here's ours for example.

{
  "extends": ["airbnb", "plugin:@next/next/recommended"],
  "plugins": ["prettier"],
  "rules": {
    "prettier/prettier": "error"
  },
  "settings": {
    "react": {
      "version": "detect"
    }
  }
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants