Skip to content

Latest commit

 

History

History
91 lines (62 loc) · 4.67 KB

Week_2.md

File metadata and controls

91 lines (62 loc) · 4.67 KB

Guidance

Answer the following questions considering the learning outcomes for this week. Make sure to record evidence of your processes. You can use code snippets, screenshots or any other material to support your answers.

Do not fill in the feedback section. The Founders and Coders team will update this with feedback on your progress.

Assessment

1. Show evidence of a learning outcome you have achieved this week.

  • GitHub Actions CI setup to run your tests when you push Screenshot 2023-09-28 at 16 00 00

[Learning outcome...]

Yml file below:

name: Fly Deploy

on:
  push:
    branches:
      - main

jobs:
  deploy:
    name: Deploy app
    runs-on: ubuntu-latest

    steps:
      - name: Checkout code
        uses: actions/checkout@v3

      - name: Set up Node.js
        uses: actions/setup-node@v2
        with:
          node-version: '18.16.0' 

      - name: Install dependencies
        run: npm install

      - name: Run tests
        run: npm test
        
      - name: Set up Flyctl
        uses: superfly/flyctl-actions/setup-flyctl@master
        with:
          api-token: ${{ secrets.FLY_API_TOKEN }}

      - name: Deploy to Fly.io
        run: flyctl deploy --remote-only
        env:
          FLY_API_TOKEN: ${{ secrets.FLY_API_TOKEN }}

2. Show an example of a learning outcome you have struggled with and/or would like to re-visit.

We decided to used a Dev Branch and push our code there before pushing our final code into main. Some of us had some issues with git such as their branch was ahead of the original branch, or accidentally merged code into main and ending with some code in the dev branch and some in main. I would like to learn more about how to set up some rules in github that will prevent us from making this mistakes in the future.

I did some research and found some interesting articles about best practices using git. Links here: https://medium.com/git-happy/10-key-best-practices-for-git-branch-management-b0e7ec4148b9

https://www.gitkraken.com/learn/git/best-practices/git-branch-strategy

I also came accross GitHub release which can potentially be a good alternative to keep your code clean, and make sure that your app is always working as expected.

GitHub Releases is a feature provided by GitHub that allows you to package and distribute specific versions of your software or project to your users or collaborators. It is a way to formally publish and distribute your project's releases, making it easier for others to understand what changes have been made in each release and to access the associated assets and documentation.

https://github.com/marketplace/actions/create-github-release

Feedback

Alphonso's Feedback

What went well

Love that you linked some resources for the learning you struggled with! Great way to show a plan for next steps. Adding the Yml script to your example in question 1 is also a nice extra detail.

Even better if

Think of explaining the why of things as well as the how of things. As a developer I love that you're thinking of ways to enforce regular testing in your project but anyone who hasn't had to manage a rapidly changing codebase will lack the context to this - even a new developer joining your team may not be accustomed to Test Driven Development. One or two lines about the reasoning behind this setup would make all the difference in the world.

It's great that you spotted potential solutions to the outcome you're struggling with but it's worth thinking of their actual application. New releases are always exciting because they generally come with the promise of solving some problem we've come up against a lot but are there possible solutions available that don't depend on a new release? The articles you linked mention best practices - having clear and steady best practice in place is usually the best solution. Consider documenting a work flow and a few best practices you would like to implement and liaising with your Scrum Facilitator to implement them in a future project. That documentation can then also serve as proof of your learning :)

Elena

Thanks for the feedback Alphonso! I definitely agree and I think it's important to consider both the why and the how. I think that when we made certain decisions, we didn't have a comprehensive understanding of how things would work, and we rushed into making choices without conducting thorough research on best practices. But it's good I learned something and next time hopefully can make things better.