Skip to content
This repository has been archived by the owner on Mar 11, 2021. It is now read-only.

Research possibility of moving some basic configuration code to common and reuse it in cluster #7

Open
alexeykazakov opened this issue Oct 3, 2018 · 0 comments

Comments

@alexeykazakov
Copy link
Contributor

fabric8-common already has configuration package - https://github.com/fabric8-services/fabric8-common/blob/master/configuration/configuration.go
But it's based on WIT configuration.
We did some important improvements in Auth and Cluster services to manage configuration errors - https://github.com/fabric8-services/fabric8-cluster/blob/master/configuration/configuration.go#L309
And we use it in our status endpoint - https://github.com/fabric8-services/fabric8-cluster/blob/master/controller/status.go#L72
So, service won't pass readiness prob if something is wrong with configuration.

It would be great if we can move some code to common and re-use it in cluster service.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant