Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

README instructions incomplete #2343

Open
jrrk2 opened this issue Dec 8, 2021 · 0 comments
Open

README instructions incomplete #2343

jrrk2 opened this issue Dec 8, 2021 · 0 comments
Labels
type-docs Issue is related to documentation.

Comments

@jrrk2
Copy link

jrrk2 commented Dec 8, 2021

The README should mention that 'cd build' is required before the described build targets can be accessed.
Also it is unclear when/if 'conda activate' should be called for this part of the flow.

Furthermore, the README talks about rerunning 'cmake'. If this is not done inside the build directory then the top-level Makefile will be overridden and things will get in a right mess.
@issuelabeler issuelabeler bot added the done label Dec 8, 2021
@umarcor umarcor added type-docs Issue is related to documentation. and removed done labels May 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type-docs Issue is related to documentation.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jrrk2 @umarcor