Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP - Use upstream scrollbar instead of custom one #2393

Closed

Conversation

MichaelAug
Copy link
Contributor

It changes the following:

  • Use upstream scrollbar instead of custom implementation

Here is an example of new scrollbar:
image

I followed the checklist:

  • I added unittests
  • I ran make check without errors
  • I tested the overall application
  • I added an appropriate item to the changelog

@extrawurst
Copy link
Owner

extrawurst commented Oct 21, 2024

This shows that we are not doing a good job of using our own abstraction everywhere, as most places draw scrollbars themselfs by directly calling draw_scrollbar.

Depending on how much time you have we should clean that up. Minimum is to also make draw_scrollbar use the ratatui widget.

Ideally though we also migrate all places directly calling draw_scrollbar to use our VerticalScroll abstraction.

Marking as draft while its WIP

@extrawurst extrawurst marked this pull request as draft October 21, 2024 07:49
@MichaelAug
Copy link
Contributor Author

yeah i've got time :) I can refactor VerticalScroll and HorizontalScroll and then replace all usages of draw_scrollbar with one of those.

Do you want this work done as part of #2155 or should we make a new issue? Do you have a preference for how this work should be split up? A single giant PR or split it up into multiple?

@extrawurst
Copy link
Owner

Ideally we open a new PR with just the migration to our existing two types and then we followup with this

@MichaelAug
Copy link
Contributor Author

Can do! Will close this PR for now then

@MichaelAug MichaelAug closed this Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants