Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pinentry for signing a commit does not recognize every key press when executed via gitui. #2395

Open
dataCobra opened this issue Oct 21, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@dataCobra
Copy link

Describe the bug

I'm using a Nitrokey with a PGP key which I also use for signing commits in multiple repositories.

When trying to commit with gitui the ncurses pinentry comes up and I try to input my password. While trying I notice that not every key press is registered and I sometimes need to press a key multiple times to get the press through to ncurses pinentry.

Also I noticed that gitui is not recovering safe from a wrong pinentry and the terminal needs a reset.

To Reproduce
Steps to reproduce the behavior:

  1. Use ncurses pinentry. (Add pinentry-program /usr/bin/pinentry-curses to your gpg-agent.conf)
  2. Open gitui and try to commit something where the pinentry comes up.
  3. pinentry is not recognizing every key press as stated in the description.

Expected behavior
Every key press gets through to the pinentry software. Like it is when using pinentry without gitui.

Context (please complete the following information):

  • OS/Distro + Version: Void Linux - Kernel 6.11.3 - UpToDate
  • GitUI Version: 0.26.3
  • Rust version: 1.82.0

Additional context
I've installed gitui via cargo install.

@dataCobra dataCobra added the bug Something isn't working label Oct 21, 2024
@Arthapz
Copy link

Arthapz commented Nov 1, 2024

i have the same issue, i tried with curse pinentry and tty one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants