Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When the terminal is insufficient to display all the commands, the cmdbar_bg configuration color does not fully take effect. #2347

Open
wugeer opened this issue Aug 30, 2024 · 2 comments · May be fixed by #2348
Labels
bug Something isn't working good first issue Good for newcomers
Milestone

Comments

@wugeer
Copy link
Contributor

wugeer commented Aug 30, 2024

Describe the bug
In my terminal, Kitty, I've customized the font size. In the GitUI window, when the commands do not fully display on one line, and I press . to show more commands, the background color of these additional commands does not match the cmdbar_bg color configured in ~/.config/gitui/theme.ron.
录屏 2024-08-30 11-59-18.webm

To Reproduce
Steps to reproduce the behavior:

  1. adjust the terminal font size to ensure that the command cannot be displayed in one line
  2. vim ~/.config/gitui/theme.ron
(
    cmdbar_bg: Some("#FFFFFF"),
)
  1. execute gitui command then express . to show more command
    4 . See the difference two command line

Expected behavior
The background color of the two lines of commands is the color configured by cmdbar_bg in ~/.config/gitui/theme.ron.

Screenshots
image

Context (please complete the following information):

  • OS/Distro + Version: [CachyOS Linux x86_64 Linux 6.6.47-1-lts]
  • GitUI Version [ gitui nightly 2024-06-02 (95e1d4d)]
  • Rust version: [rustc 1.80.1 (3f5fd8dd4 2024-08-06)]
@wugeer wugeer added the bug Something isn't working label Aug 30, 2024
@wugeer wugeer changed the title When the terminal font is insufficient to display all the commands, the cmdbar_bg configuration color does not fully take effect. When the terminal is insufficient to display all the commands, the cmdbar_bg configuration color does not fully take effect. Aug 30, 2024
@extrawurst
Copy link
Owner

interesting. good catch!

@extrawurst extrawurst added the good first issue Good for newcomers label Aug 30, 2024
@extrawurst extrawurst added this to the v0.27 milestone Aug 30, 2024
@wugeer
Copy link
Contributor Author

wugeer commented Aug 30, 2024

@extrawurst hello, maybe I have discovered why this problem occurs. I would like to ask what is the meaning of the fields cmdbar_extra_lines_bg and cmdbar_bg under struct Theme? From my personal perspective, cmdbar_extra_lines_bg actually does not need to exist, the background of cmdbar should remain consistent.
I will submit a PR to fix this issue later. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
2 participants