Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependency on cookie version 0.6.0 triggers an npm audit failure #996

Open
hello-alf opened this issue Oct 7, 2024 · 5 comments
Open

Dependency on cookie version 0.6.0 triggers an npm audit failure #996

hello-alf opened this issue Oct 7, 2024 · 5 comments

Comments

@hello-alf
Copy link

hello-alf commented Oct 7, 2024

According to Github GHSA-pxg6-pf52-xh8x
accepts cookie name, path, and domain with out of bounds characters

The solution to resolve the npm audit failure is to upgrade the cookie dependency from version 0.6.0 to version 0.7.0. This update addresses the security vulnerabilities identified in the audit.

@UlisesGascon
Copy link
Member

@hello-alf if you are using Express... we are going to release a new version soon with the updated version included. See: expressjs/express#6017

@knolleary
Copy link
Contributor

@UlisesGascon can you clarify if doing the express release will also cause this repo to have its dependency updated and released?

We depend on both express and express-session - which both currently depend on cookie 0.6.0. Having a new release of express will be great, but we need express-session updating as well.

@UlisesGascon UlisesGascon reopened this Oct 8, 2024
@UlisesGascon
Copy link
Member

My fault, you are right @knolleary. We need to update cookie version in this repo too. Are willing to create the PR, @knolleary ? 👍

@knolleary
Copy link
Contributor

@UlisesGascon #997 - hope I've follow the right conventions for the HISTORY file update.

@UlisesGascon
Copy link
Member

This will be solve once 1.1.18 is released #998

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants