Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#48in24: Meetup 2024-08-20 and PHP is a featured language #667

Closed
4 of 8 tasks
mk-mxp opened this issue Mar 27, 2024 · 4 comments
Closed
4 of 8 tasks

#48in24: Meetup 2024-08-20 and PHP is a featured language #667

mk-mxp opened this issue Mar 27, 2024 · 4 comments

Comments

@mk-mxp
Copy link
Contributor

mk-mxp commented Mar 27, 2024

Meetup will be the only exercise with PHP as featured language during #48in24! Let's prepare it well:

  • Run bin/configlet sync -u -e meetup --yes --docs --filepaths --metadata --tests include (updates the Markdown files and maybe tests.toml)
    • docs: instructions unsynced: meetup
    • metadata: unsynced: meetup
  • Drop strict types comments from test file and example code (these are useless)
  • Add and sync test meta data to tests (uuid / @testdox in DocBlocks)
  • Decide on adding / adjusting / ordering test cases to match current problem specs

Do not redesign the student's interface or add test cases that would invalidate existing community solutions. These are extra tasks, which should be discussed in advance.

In addition to the other sync-ing tasks, consider doing these:

@mk-mxp mk-mxp pinned this issue Mar 27, 2024
@mk-mxp mk-mxp changed the title #48in24 (Week 32): Meetup and PHP is a featured language #48in24: Meetup 2024-08-20 and PHP is a featured language Apr 6, 2024
@sarad1p1ty
Copy link
Contributor

Hi,
If this is the featured task for next week, I could have a look today/tomorrow?

@mk-mxp
Copy link
Contributor Author

mk-mxp commented Aug 16, 2024

@sarad1p1ty Yes, you are welcome! The first 4 checkpoints are some kind of minimum points to have (but there might be nothing to do). And hopefully there are no surprises in the 4th point.

The data for UUID, @testdox nice test name and the 4th point is taken from this file: https://github.com/exercism/problem-specifications/blob/main/exercises/meetup/canonical-data.json

To locally test against the changed test cases, you may copy the example.php contents into the student stub Meetup.php and run PHPUnit against it: vendor/bin/phpunit --no-configuration --do-not-cache-result exercise/practice/meetup/MeetupTest.php. Or use composer ci if you solved the problems you had with that.

In case of any trouble: I do have little time until Monday. But I'll do my very best to answer all questions.

@mk-mxp
Copy link
Contributor Author

mk-mxp commented Aug 16, 2024

@sarad1p1ty And you may take a look at #779 for an example of a sync PR. Please note: The uuid must be before @testdox in the DocBlock comment.

@sarad1p1ty
Copy link
Contributor

That's really helpful. Thank you!
I will let you know if I run into any problems.

sarad1p1ty added a commit to sarad1p1ty/exercism-php that referenced this issue Aug 17, 2024
sarad1p1ty added a commit to sarad1p1ty/exercism-php that referenced this issue Aug 17, 2024
sarad1p1ty added a commit to sarad1p1ty/exercism-php that referenced this issue Aug 19, 2024
sarad1p1ty added a commit to sarad1p1ty/exercism-php that referenced this issue Aug 19, 2024
sarad1p1ty added a commit to sarad1p1ty/exercism-php that referenced this issue Aug 19, 2024
sarad1p1ty added a commit to sarad1p1ty/exercism-php that referenced this issue Aug 19, 2024
@mk-mxp mk-mxp closed this as completed Aug 19, 2024
@mk-mxp mk-mxp unpinned this issue Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants