[lens-person] Remove get and set methods
#2559
Conversation
|
Hello. Thanks for opening a PR on Exercism 🙂 We ask that all changes to Exercism are discussed on our Community Forum before being opened on GitHub. To enforce this, we automatically close all PRs that are submitted. That doesn't mean your PR is rejected but that we want the initial discussion about it to happen on our forum where a wide range of key contributors across the Exercism ecosystem can weigh in. You can use this link to copy this into a new topic on the forum. If we decide the PR is appropriate, we'll reopen it and continue with it, so please don't delete your local branch. If you're interested in learning more about this auto-responder, please read this blog post. Note: If this PR has been pre-approved, please link back to this PR on the forum thread and a maintainer or staff member will reopen it. |
|
This PR touches files which potentially affect the outcome of the tests of an exercise. This will cause all students' solutions to affected exercises to be re-tested. If this PR does not affect the result of the test (or, for example, adds an edge case that is not worth rerunning all tests for), please add the following to the merge-commit message which will stops student's tests from re-running. Please copy-paste to avoid typos. For more information, refer to the documentation. If you are unsure whether to add the message or not, please ping |
|
@Cool-Katt I think you're supposed to have write-access. @ErikSchierboom do you know why they don't? |
I thought so too, but I realized I never tried merging anything until now, so here we are. I think it's because the role that's given to exercism/javascript is triage so basically like write access but no merging of PRs, as I understood from the docs. |
|
As far as I'm concerned you should get rights given the fact you accepted the maintainer position. Can you ping the peeps in your maintainer acceptance issue about this? |
It was this. Fixed now. |
The methods were unused. Discussion here