Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync Rectangles tests with problem spec #2551

Merged
merged 2 commits into from
Nov 1, 2024

Conversation

themetar
Copy link
Contributor

@themetar themetar commented Nov 1, 2024

Added a missing test from problem specification.

Copy link
Contributor

github-actions bot commented Nov 1, 2024

This PR touches files which potentially affect the outcome of the tests of an exercise. This will cause all students' solutions to affected exercises to be re-tested.

If this PR does not affect the result of the test (or, for example, adds an edge case that is not worth rerunning all tests for), please add the following to the merge-commit message which will stops student's tests from re-running. Please copy-paste to avoid typos.

[no important files changed]

For more information, refer to the documentation. If you are unsure whether to add the message or not, please ping @exercism/maintainers-admin in a comment. Thank you!

Copy link
Contributor

github-actions bot commented Nov 1, 2024

Hello. Thanks for opening a PR on Exercism 🙂

We ask that all changes to Exercism are discussed on our Community Forum before being opened on GitHub. To enforce this, we automatically close all PRs that are submitted. That doesn't mean your PR is rejected but that we want the initial discussion about it to happen on our forum where a wide range of key contributors across the Exercism ecosystem can weigh in.

You can use this link to copy this into a new topic on the forum. If we decide the PR is appropriate, we'll reopen it and continue with it, so please don't delete your local branch.

If you're interested in learning more about this auto-responder, please read this blog post.


Note: If this PR has been pre-approved, please link back to this PR on the forum thread and a maintainer or staff member will reopen it.

@github-actions github-actions bot closed this Nov 1, 2024
@SleeplessByte SleeplessByte reopened this Nov 1, 2024
@SleeplessByte
Copy link
Member

/format

Copy link
Contributor

github-actions bot commented Nov 1, 2024

The "Format code" action has started running.

Copy link
Contributor

github-actions bot commented Nov 1, 2024

The "Format code" action has finished running.

Copy link
Contributor

github-actions bot commented Nov 1, 2024

For security reasons, /format does not trigger CI builds when the PR has been submitted from a fork. If checks were not passing due to code format, trigger a build to make the required checks pass, through one of the following ways:

  • Push an empty commit to this branch: git commit --allow-empty -m "Trigger builds".
  • Close and reopen the PR.
  • Push a regular commit to this branch.

@SleeplessByte SleeplessByte reopened this Nov 1, 2024
@SleeplessByte SleeplessByte merged commit be7d58f into exercism:main Nov 1, 2024
6 checks passed
@themetar themetar deleted the sync-rectangles branch November 6, 2024 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants